TextActual should probably not be exposed in the public API

JetBrains / compose-multiplatform

Compose Multiplatform, a modern UI framework for Kotlin that makes building performant and beautiful user interfaces easy and enjoyable.

https://jetbrains.com/lp/compose-multiplatform

Apache License 2.0

15.95k stars 1.16k forks source link

TextActual should probably not be exposed in the public API #782

Open LouisCAD opened 3 years ago

LouisCAD commented 3 years ago

Hello, I was wondering why composables with names like TextActual are part of the public API when it seems they're designed to be called by Text and alike.

I think they should be internal. If there's any issue preventing to apply the correct visibility, I'd be happy to get the link to it, and it'd be great that it's mentioned in the code comments as well to prevent further confusion.

Have a great day! Louis CAD

olonho commented 3 years ago

It was implemented that way due to https://youtrack.jetbrains.com/issue/KT-34823, which seems to be fixed.

okushnikov commented 3 weeks ago

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.