2.0 - document how IDE sources are managed

JetBrains / intellij-platform-gradle-plugin

Gradle plugin for building plugins for IntelliJ-based IDEs

https://plugins.jetbrains.com/docs/intellij/gradle-prerequisites.html

Apache License 2.0

1.42k stars 271 forks source link

2.0 - document how IDE sources are managed #1629

Closed jonathanlermitage closed 2 months ago

jonathanlermitage commented 4 months ago

Describe the need of your request

Using plugin v2
According to https://plugins.jetbrains.com/docs/intellij/tools-intellij-platform-gradle-plugin-migration.html#intellijdownloadsources:

Downloading sources is managed by the Plugin DevKit plugin in version 2024.1+.

What does it mean exactly? Does it download IDE's sources automatically for stable IDE versions, and not for EAP builds? (this is what I'm trying to do). Plugin v1 offered us to control that. If we lose control when switching to v2, a more detailed documentation would be helpful. Users may not want to download IDE sources when targeting an EAP build, and when running in a CI. I guess this is the default behavior, but I'm not sure. Thx.

Proposed solution

Clarify documentation.

Alternatives you've considered

No response

Additional context

No response

jansorg commented 3 months ago

Currently, with beta6 sources were neither downloaded for stable releases (IC-2024.1.1) nor for EAPs (IC-242.15523.18-EAP-SNAPSHOT). I've enabled Gradle: Download sources in the advanced settings. It's unclear to me if this is a bug or how I could control the download of sources. I very much would like to get sources for development...

chylex commented 2 months ago

IdeaVim has migrated to 2.0 and I can't figure out how to get sources to work either. I clicked "Download IntelliJ Platform sources", then I got this:

obrazek

and clicking Yes did nothing. I reverted the commit to migrate to 2.0 in my IdeaVim fork, and sources got attached without any issues.

jonathanlermitage commented 2 months ago

Sources download no longer work for me. When I click the button in order to download platform's sources, I see this message, I accept, but it does nothing:

IJ Ult 2024.1.4. Plugin 2.0.0-beta8, Gradle 8.8.
It worked last week with the same IDE, plugin, gradle, and targeted IDE version (2024.1.4 Community).
I cleared my gradle cache then reimported my projects, but it did not help.

hsz commented 2 months ago

I tis now fixed with IJPL-158473 and will be released in IntelliJ IDEA 2024.1.5 and 2024.2.

Docs are updated here: https://plugins.jetbrains.com/docs/intellij/tools-intellij-platform-gradle-plugin.html#attaching-sources