search

JetBrains / intellij-platform-gradle-plugin

Gradle plugin for building plugins for IntelliJ-based IDEs
https://plugins.jetbrains.com/docs/intellij/gradle-prerequisites.html
Apache License 2.0
1.4k stars 270 forks source link

2.0 - migration plugin should say if something is wrong #1630

Open jonathanlermitage opened 1 month ago

jonathanlermitage commented 1 month ago

Describe the need of your request

Using plugin id("org.jetbrains.intellij.platform.migration") version "2.0.0-beta3"
It always says:

As soon as you'll handle all configuration problems, remember to remove this plugin from your plugins {} block and eventually rename the intellij {} extension to intellijPlatform {}. Note: We encourage avoiding configuring tasks directly, like: patchPluginXml { ... }, publishPlugin { ... }, signPlugin { ... }, ... Use the intellijPlatform { } extension instead: ...

But it doesn't say what's wrong with my build.

Proposed solution

The migration plugin should enumerate what's wrong or, if everything is okay, it should say it found no issue.

Alternatives you've considered

No response

Additional context

I am not using publishPlugin and signPlugin, only patchPluginXml. For this last one, I found no documentation about this. We have documentation for plugin v1 https://plugins.jetbrains.com/docs/intellij/tools-gradle-intellij-plugin.html#tasks-patchpluginxml, but how to migrate patchPluginXml to plugin v2 (if needed, I have no idea)? I can package my plugin with success. I guess the migration plugin simply found no issue, but I'm not sure.

YannCebron commented 1 month ago

That text is just a general warning. Indeed, it should list/highlight deprecated properties and problems from your 1.x build file.

Not quite sure what the problem is without an actual sample and expected vs actual.

tim-sh commented 3 weeks ago

As far as I'm concerned, just use any IJ plugin built with IntelliJ Platform Gradle Plugin 1 and try to use org.jetbrains.intellij.platform.migration (add to or replace existing plugin reference org.jetbrains.intellij.platform) in build.gradle. Build errors continue to happen one by one during gradle buildPlugin, and the migration plugin does not give any hints in the IDE.

tim-sh commented 1 week ago

@YannCebron Any hints on how to get this migration plugin to get to work would be appreciated.