JetBrains / intellij-platform-plugin-template

Template repository for creating plugins for IntelliJ Platform
Apache License 2.0
3.05k stars 618 forks source link

Plugin Verifier Cache is passed incorrectly in GH Action #339

Closed abrooksv closed 1 year ago

abrooksv commented 1 year ago

Describe the bug: The GitHub actions passes it with -P which is a Gradle property:

https://github.com/JetBrains/intellij-platform-plugin-template/blob/43896299abbbf5ea802604530b7305da52c06675/.github/workflows/build.yml#L104-L105

But the Gradle plugin wants it as a System Property:

https://github.com/JetBrains/gradle-intellij-plugin/blob/68435e0d5c01e9b490a91bf3914459693e4700ef/src/main/kotlin/org/jetbrains/intellij/tasks/RunPluginVerifierTask.kt#L123-L128

Steps to reproduce: You can see that the saving of the cache is always empty, indicating that it wrote the actual IDEs to a different directory: https://github.com/JetBrains/intellij-platform-plugin-template/actions/runs/3759691070/jobs/6389670166#step:28:3

This can be seen as true in the Gradle task: https://github.com/JetBrains/intellij-platform-plugin-template/actions/runs/3759691070/jobs/6389670166#step:11:56

Expected behavior: Cache should be respected out of the box.

Either:

  1. Pass with -D
  2. Change Gradle plugin to read gradle property as well (list is getting long at that point 😄 )
  3. Change Setup Plugin Verifier IDEs Cache to not use a custom directory, but one of the defaults
Konafets commented 1 year ago

In my repo I used -D to pass the path correctly and corrected the path. That works but I do not see any performance improvements on this change.

hsz commented 1 year ago

Fixed in 1.5.0