Closed abrooksv closed 1 year ago
Describe the bug: The GitHub actions passes it with -P which is a Gradle property:
https://github.com/JetBrains/intellij-platform-plugin-template/blob/43896299abbbf5ea802604530b7305da52c06675/.github/workflows/build.yml#L104-L105
But the Gradle plugin wants it as a System Property:
https://github.com/JetBrains/gradle-intellij-plugin/blob/68435e0d5c01e9b490a91bf3914459693e4700ef/src/main/kotlin/org/jetbrains/intellij/tasks/RunPluginVerifierTask.kt#L123-L128
Steps to reproduce: You can see that the saving of the cache is always empty, indicating that it wrote the actual IDEs to a different directory: https://github.com/JetBrains/intellij-platform-plugin-template/actions/runs/3759691070/jobs/6389670166#step:28:3
This can be seen as true in the Gradle task: https://github.com/JetBrains/intellij-platform-plugin-template/actions/runs/3759691070/jobs/6389670166#step:11:56
Expected behavior: Cache should be respected out of the box.
Either:
Setup Plugin Verifier IDEs Cache
In my repo I used -D to pass the path correctly and corrected the path. That works but I do not see any performance improvements on this change.
-D
Fixed in 1.5.0
Describe the bug: The GitHub actions passes it with -P which is a Gradle property:
https://github.com/JetBrains/intellij-platform-plugin-template/blob/43896299abbbf5ea802604530b7305da52c06675/.github/workflows/build.yml#L104-L105
But the Gradle plugin wants it as a System Property:
https://github.com/JetBrains/gradle-intellij-plugin/blob/68435e0d5c01e9b490a91bf3914459693e4700ef/src/main/kotlin/org/jetbrains/intellij/tasks/RunPluginVerifierTask.kt#L123-L128
Steps to reproduce: You can see that the saving of the cache is always empty, indicating that it wrote the actual IDEs to a different directory: https://github.com/JetBrains/intellij-platform-plugin-template/actions/runs/3759691070/jobs/6389670166#step:28:3
This can be seen as true in the Gradle task: https://github.com/JetBrains/intellij-platform-plugin-template/actions/runs/3759691070/jobs/6389670166#step:11:56
Expected behavior: Cache should be respected out of the box.
Either:
Setup Plugin Verifier IDEs Cache
to not use a custom directory, but one of the defaults