JetBrains / intellij-platform-plugin-template

Template repository for creating plugins for IntelliJ Platform
Apache License 2.0
3.05k stars 618 forks source link

fix: Remove getLatest() from changeNotes in patchPluginXml task #340

Closed Blarc closed 1 year ago

Blarc commented 1 year ago

The current implementation of the changeNotes in the patchPluginXml task is incorrect. It calculates changes based on the latest version rather than the unreleased version, resulting in a plugin XML file that includes the changelog for the previous version instead of the one being released (as seen on https://plugins.jetbrains.com/plugin/19411-gitlab-template-lint/versions).

This merge request aims to correct this issue by removing the getLatest() method and adding the withHeader(false) and withEmptySection(false) options to remove unnecessary elements from the changelog.

codecov-commenter commented 1 year ago

Codecov Report

Base: 45.00% // Head: 45.00% // No change to project coverage :thumbsup:

Coverage data is based on head (348f619) compared to base (4389629). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## next #340 +/- ## ======================================= Coverage 45.00% 45.00% ======================================= Files 4 4 Lines 20 20 Branches 3 3 ======================================= Hits 9 9 Misses 9 9 Partials 2 2 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JetBrains). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JetBrains)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

hsz commented 1 year ago

Thank you, Jakob! BTW — you've applied with* just to the getUnreleased() but a simple (...) will work here.