search

JetBrains / intellij-platform-plugin-template

Template repository for creating plugins for IntelliJ Platform
Apache License 2.0
3.05k stars 618 forks source link

fix JVM toolchain download #473

Open jonathanlermitage opened 3 weeks ago

jonathanlermitage commented 3 weeks ago

The build.gradle.kts defines a JVM toolchain, but if no compatible JDK is found, no JDK is downloaded and the build fails.
To download a JDK automatically if needed, we need the org.gradle.toolchains.foojay-resolver-convention plugin. Tested on Arch Linux, with JDK21 installed: after adding the foojay plugin, ./gradlew buildPlugin no longer fails, and it downloads a compatible JDK17.

codecov-commenter commented 3 days ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 26.92%. Comparing base (ae35708) to head (dbe7b10). Report is 85 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #473 +/- ## ========================================== - Coverage 27.58% 26.92% -0.67% ========================================== Files 4 4 Lines 29 26 -3 ========================================== - Hits 8 7 -1 + Misses 21 19 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.