search

JetBrains / jetpad-projectional-open-source

jetpad-projectional
Apache License 2.0
72 stars 13 forks source link

Draft API for selection, compatibility layer for SelectionSupport #240

Closed CheatEx closed 8 years ago

CheatEx commented 8 years ago

With review notes from PR #237

timzam commented 8 years ago

Looks good to me. We could decide on the id type later.

katepol commented 8 years ago

OK with me, though I'd like to make SelectionSupport.setSelectionController() package local. I can't see matching pull request to datapad for merge.

CheatEx commented 8 years ago

I'm not aware about the process of synchronous merge. I assumed the person who merges this could fix the import in StatementCell.

On Thu, Apr 21, 2016 at 8:09 PM, Ekaterina Frolova <notifications@github.com

wrote:

OK with me, though I'd like to make SelectionSupport.setSelectionController() package local. I can't see matching pull request to datapad for merge.

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/JetBrains/jetpad-projectional/pull/240#issuecomment-213021073

timzam commented 8 years ago

It's not only an import. You should have prepared a pull request in datapad as well.

C:\jetpad\JetBrains\datapad\components\input-output-editor\src\main\java\jetbrains\datapad\inputOutputEditor\mapper\toDom\modelInput\CollaboratorsSupportImpl.java Error:(356, 55) java: SELECTION_SUPPORT is not public in jetbrains.jetpad.projectional.selection.SelectionSupport; cannot be accessed from outside package Error:(357, 28) java: isLowerPrioritySelection() is not public in jetbrains.jetpad.projectional.selection.SelectionSupport; cannot be accessed from outside package

CheatEx commented 8 years ago

@timzam https://github.com/JetBrains/datapad/pull/17