Selection escalated if lower-level selection found

aleksei-berezkin commented 8 years ago

Effect is better visible in apps that have both hybrid and projectional editors. If you select some tokens up to the line end, and then continue selection, tokens selections is promoted to projectional selection, and also the next line selected. Earlier tokens selection was dropped.

Warning: this will break tests of https://github.com/JetBrains/jetpad-projectional/pull/247. After you accept latter, please give me some time to merge from master and change tests.

aleksei-berezkin commented 8 years ago

Changes in two last commits:

Merged from master, resolved conflicts, now safe to merge;
Positions.isEmpty() introduced;
hasLowerSelection methods renamed so they now look symmetrically though named a bit longer than @timzam suggested;
Lowered methods visibility where possible.

~~Because there was merge from master, simple squash not possible, will have to create a new request and reimplement SelectionControllerLegacyTest. So could you please accept as is?~~

UPD Just realized I can simply count a diff between two HEADs and commit this diff.

aleksei-berezkin commented 8 years ago

Please consider one-commit version.

JetBrains / jetpad-projectional-open-source

Selection escalated if lower-level selection found #249