DP-1136 Fixed uncommenting a comment with a nested comment

JetBrains / jetpad-projectional-open-source

jetpad-projectional

Apache License 2.0

72 stars 13 forks source link

DP-1136 Fixed uncommenting a comment with a nested comment #250

Closed aleksei-berezkin closed 8 years ago

aleksei-berezkin commented 8 years ago

Changes in TextEditingTrait caused by possible processed token removal (resulting in cell detach). Earlier current token also had a chance to be removed, but this was happening in other paths which took this into a consideration and no error was encountered.

Changes in TextEditingTrait are covered by new and some old tests.

timzam commented 8 years ago

I noticed that the pasteBeforeComment test is passing without the changes in the commit. Is it expected?

aleksei-berezkin commented 8 years ago

@timzam The test proves changes in TextEditingTrait.onPaste() needed for new version on uncomment processing in TokenCellTraits. Applying only latter will fail the test.

timzam commented 8 years ago

I see. Looks good to me.