JetBrains / jewel

An implementation of the IntelliJ look and feels in Compose for Desktop
Apache License 2.0
751 stars 40 forks source link

SelectableLazyColumn perf/code review #242

Open rock3r opened 1 year ago

rock3r commented 1 year ago

The SelectableLazyColumn is a foundational component that will be used everywhere. As such, we need to make it work as well as it possibly can. This issue is to track the need to do a thorough code and perf review of the component, fixing any issues we find.


Known concerns

Walingar commented 1 year ago

Also, there is a usecase that should be taken into account:

Imagine we have a textfield and lazy column where elements can be selected (e.g. Search Everywhere or Git Branches popup) I want to propagate arrowDown/arrowUp presses to lazy list. So that when TextField is focused and arrowDown is pressed, lazy list become focused and arrowDown is handled by lazy list.

Now events handling is incapsulated in SelectableLazyColumn, so supporting this scenario is quite difficult

rock3r commented 1 month ago

Related: #470