search

JetBrains / jewel

An implementation of the IntelliJ look and feels in Compose for Desktop
Apache License 2.0
636 stars 30 forks source link

Use value classes for inline markdown #329 #331

Closed obask closed 3 months ago

obask commented 3 months ago

This classes wrap CommonMark's nodes and preserve a familiar API. Some tests were turned off because we don't use the same IR for string serialization.

Changing dataclasses to values classes for blocks is coming in the next pull request.

obask commented 3 months ago

I thought that it makes scrolling errors more prominent, but it looks exactly the same as before... not sure if the bug is in CfD or the way we represent lists or remember some nodes... which is probably not the case, because these nodes don't change during rendering at all.

rock3r commented 3 months ago

You need to run the apiDump task for this to go green :)