search

JetBrains / jewel

An implementation of the IntelliJ look and feels in Compose for Desktop
Apache License 2.0
636 stars 30 forks source link

Add tables extension #339

Open obask opened 3 months ago

obask commented 3 months ago

*please ignore commits before Wire up GFM Tables extension

obask commented 3 months ago

Also, maybe we could make most of the nodes data classes, but it will require merging some underlying CLs to make inline nodes value classes.

rock3r commented 3 months ago

@obask you'll need to sort out conflicts in this PR and in others for me to ship them. Please make sure you stack PRs that have dependencies.

obask commented 3 months ago

@obask you'll need to sort out conflicts in this PR and in others for me to ship them. Please make sure you stack PRs that have dependencies.

As I mentioned before, I don't have rights to push to existing branches making this impossible: $ git push -u origin migrate-components

For example, this check is a requirement for feature branches https://github.com/JetBrains/jewel/blob/main/.github/workflows/codeql.yml#L7, but I don't think running it in a fork will give me an ability to push to origin aka JetBrains/jewel. The only working solution for an existing setup would be to create a new stacked PR every time I "address comments".

rock3r commented 3 months ago

You have full write access to this repository, you shouldn't need to have a fork. I have weakened the branch protection rules even more than they already were. You should be able to push and force push to any branch directly with the exception of main.

obask commented 3 months ago

Let's sync on that over video when you have time. I'm getting the same error:

oleg@Olegs-MacBook-Air jewel % git commit -m 'Test branch protection rules'
[test-branch-protection-rules baced50] Test branch protection rules
 1 file changed, 1 insertion(+)
oleg@Olegs-MacBook-Air jewel % git push
Enumerating objects: 23, done.
Counting objects: 100% (23/23), done.
Delta compression using up to 8 threads
Compressing objects: 100% (7/7), done.
Writing objects: 100% (12/12), 785 bytes | 785.00 KiB/s, done.
Total 12 (delta 5), reused 0 (delta 0), pack-reused 0
remote: Resolving deltas: 100% (5/5), completed with 5 local objects.
remote: error: GH006: Protected branch update failed for refs/heads/test-branch-protection-rules.
remote: error: 2 of 2 required status checks are expected.
To github.com:JetBrains/jewel.git
 ! [remote rejected] test-branch-protection-rules -> test-branch-protection-rules (protected branch hook declined)
error: failed to push some refs to 'github.com:JetBrains/jewel.git'
rock3r commented 3 months ago

Oh btw make sure all extensions are registered in the mergeSarif task — I suspect we may have forgotten that for previous PRs, too — not just this one. See https://github.com/JetBrains/jewel/blob/5d33bd5a333fbd9b243def704bc7d02086334c23/build.gradle.kts#L8-L21