JetBrains / jewel

An implementation of the IntelliJ look and feels in Compose for Desktop
Apache License 2.0
636 stars 30 forks source link

Jewel theme text style is not applied in markdown blocks #370

Closed Yashobanta-Kumar-Behera closed 2 months ago

Yashobanta-Kumar-Behera commented 2 months ago

As i can see in the file MarkdownIntUiStyling the following text size is hardcoded

private val defaultTextSize = 13.sp

private val defaultTextStyle
    get() =
        JewelTheme.createDefaultTextStyle(
            fontSize = defaultTextSize,
            lineHeight = defaultTextSize * 1.5,
        )

Is this done intentionally or support can be added to override text size in default markdown styling

rock3r commented 2 months ago

You can use the markdown styling constructor to provide a different base text style with whatever size you prefer

rock3r commented 2 months ago

To be clear the Markdown styling is still very new and will improve over time. One thing it should probably do is to use the other composition locals (content colour and text style) to define the base text style.

Yashobanta-Kumar-Behera commented 2 months ago

Yes I am clear but in order to change only text size have to build entire Markdown styling elements.

rock3r commented 2 months ago

Yes, see previous comment.

Yashobanta-Kumar-Behera commented 2 months ago

Ok Thanks