JetBrains / jewel

An implementation of the IntelliJ look and feels in Compose for Desktop
Apache License 2.0
634 stars 30 forks source link

Markdown models don't have equals/hashcode implementation #416

Open rock3r opened 6 days ago

rock3r commented 6 days ago

Since https://github.com/JetBrains/jewel/pull/331, equality and hashcode checks on ALL Markdown entities are meaningless, since all those models are value classes wrapping CommonMark models. CommonMark models do NOT implement equals and hashcode. This is potentially problematic for Compose usages, and many other cases.

We need to revert #331, since value classes do not support custom equals and hashcode implementations and we cannot rely on CommonMark models. We need true, content-based equals and hashcodes.