JetBrains / js-graphql-intellij-plugin

GraphQL language support for WebStorm, IntelliJ IDEA and other IDEs based on the IntelliJ Platform.
https://jimkyndemeyer.github.io/js-graphql-intellij-plugin/
MIT License
879 stars 97 forks source link

No spelling mistake warnings for my graphql variables #477

Open jeggy opened 3 years ago

jeggy commented 3 years ago

Describe the bug I would expect to get spelling mistake information on my GraphQL variables

To Reproduce Link to Repo with Reproduction or Steps to Reproduce:

  1. Create a query/mutation somewhere which includes variables
  2. Have spelling mistakes within your variable name
  3. See that nothing is wrong

Expected behavior I would expect to get the same spelling error help like with other variables within IntelliJ in my GraphQL variable names.

Screenshots Here you can see how IntelliJ shows my mistake on my JavaScript variable, but not in my GraphQL variable image

Version and Environment Details Operation system: Windows 10 IDE name and version: IntelliJ IDEA 2021.1.3 (Ultimate Edition) Plugin version: 2.9.1

vepanimas commented 3 years ago

Hi! Fixed it, will be available in the next release.

jeggy commented 3 years ago

I got the update today and it looks great. But it's only working for the query naming and not variables as seen on the image below:

image

vepanimas commented 3 years ago

Hi! I enabled generic support for most of the GQL entities, e.g. fields, query names, arguments, etc. But with variables there is an issue that their current implementation is still not completed, you can't resolve variable references and rename them, for example. This breaks spellchecker inspection, so I need to fix it first and I'm going to do it ASAP. I'll reopen this issue for now, though. Thank you for your feedback!