JetBrains / kotless

Kotlin Serverless Framework
Apache License 2.0
1.15k stars 58 forks source link

Gradle plugin: Make Autowarm 'minutes' an optional parameter #87

Closed s-leigh closed 3 years ago

s-leigh commented 3 years ago

It seemed silly that I had to write Autowarm(enable = false, minutes = -1) when there's no need to supply a minutes parameter when disabling autowarming. So this is a little fix for that 😄

I'd have preferred to make the minutes param nullable, but that would have had far-reaching consequences I wasn't comfortable with.

On the subject of autowarming, I personally don't think that it should be enabled by default. Apart from meaning that you'd just have to specify Autowarm(minutes = x), which is more elegant, it seems strange to have something like that on by default, especially given that people are now moving more to reserved concurrency. As a new user, it didn't even occur to me that it would be on by default - it really isn't clear in the docs.