search

JetBrains / kotlin-native

Kotlin/Native infrastructure
Apache License 2.0
7.02k stars 564 forks source link

Remove .git directory when downloading googletest sources #4715

Closed ilmat192 closed 3 years ago

ilmat192 commented 3 years ago

Keeping the .git folder in the googletest directory may cause changing .idea/vcs.xml during IDEA import. .idea/vcs.xml is under source control, thus changing it litters a current diff.

ilmat192 commented 3 years ago

maybe git archive better solution here?

It seems interesting but I haven't managed to make it work with github repos:

$ git archive -o googletest.zip -0 --remote=https://github.com/google/googletest.git master
fatal: operation not supported by protocol
$ git archive -o googletest.zip -0  --remote=git@github.com:google/googletest.git master
Invalid command: 'git-upload-archive 'google/googletest.git''
  You appear to be using ssh to clone a git:// URL.
  Make sure your core.gitProxy config option and the
  GIT_PROXY_COMMAND environment variable are NOT set.
fatal: the remote end hung up unexpectedly

It seems that GitHub doesn't support git archive. Discussed offline and decided to merge the change as is.