search

JetBrains / kotlin-native

Kotlin/Native infrastructure
Apache License 2.0
7.02k stars 565 forks source link

Update build logic #4748

Closed IgorGanapolsky closed 3 years ago

IgorGanapolsky commented 3 years ago

Migrate to AndroidX libraries for android client. Fix gradle.properties to build in XCode. Remove deprecated jcenter() package dependency, as it is deprecated.

SvyatoslavScherbina commented 3 years ago

Thank you for your contribution! As stated in the readme, the development of the kotlin-native master branch was moved to https://github.com/JetBrains/kotlin (see kotlin-native/ subdirectory). Please move this PR to kotlin repo.

IgorGanapolsky commented 3 years ago

@SvyatoslavScherbina Unfortunately that Kotlin repo cannot be built.

Required environment variables are missing: JDK_9

SvyatoslavScherbina commented 3 years ago

It is not required to build Kotlin in order to build the sample: just remove this line: https://github.com/JetBrains/kotlin/blob/75d9cd3814c95dc64227ef6bbe2854e8bab754d3/kotlin-native/samples/calculator/gradle.properties#L15

IgorGanapolsky commented 3 years ago

Tried that. Still expects JDK_9. That README file states:

Build environment requirements

SvyatoslavScherbina commented 3 years ago

Tried that. Still expects JDK_9. That README file states:

I can't confirm this.

That README file states: Build environment requirements

Do you refer to https://github.com/JetBrains/kotlin#build-environment-requirements? In this case, again, if you remove that line from gradle.properties, you won't be required to build Kotlin itself.

Please try to remove the line and then build only the calculator sample.