search

JetBrains / kotlin-wrappers

Kotlin wrappers for popular JavaScript libraries
Apache License 2.0
1.33k stars 165 forks source link

node.fs.stat: overload resolution ambiguity #2223

Closed vlsi closed 3 months ago

vlsi commented 4 months ago

https://github.com/JetBrains/kotlin-wrappers/blob/356dd827256c6d37574b01e8101e8713524ebacf/kotlin-node/src/jsMain/generated/node/fs/stat.suspend.kt#L8

https://github.com/JetBrains/kotlin-wrappers/blob/356dd827256c6d37574b01e8101e8713524ebacf/kotlin-node/src/jsMain/generated/node/fs/stat.suspend.kt#L20

sample error

1.0.0-pre.709

lppedd commented 4 months ago

I'm conflicted on what the better approach is:

  1. use LowPriorityInOverloadResolution
  2. rename the functions and use @JsName
turansky commented 4 months ago

It's regression, we can fix it without annotations and renaming

turansky commented 3 months ago

@Leonya Could you please release these changes?