search

JetBrains / lincheck

Framework for testing concurrent data structures
Mozilla Public License 2.0
555 stars 31 forks source link

Tests fail from `Thread.stop` call as of JDK 20(?) #210

Closed cpovirk closed 5 months ago

cpovirk commented 1 year ago

Since that method now throws UnsupportedOperationException, we're seeing failures, e.g.,

java.lang.UnsupportedOperationException
    at java.base/java.lang.Thread.stop([Thread.java:1654](https://cs.corp.google.com/#search/&sq=package:%5Epiper$%20project:openjdk&q=java/lang/Thread.java:1654&ws=tap-presubmit-rerun-server/4622332&snapshot=2))
    at org.jetbrains.kotlinx.lincheck.runner.FixedActiveThreadsExecutor.close([FixedActiveThreadsExecutor.kt:220](http://www.docjar.com/html/api/org/jetbrains/kotlinx/lincheck/runner/FixedActiveThreadsExecutor.kt.html))
    at org.jetbrains.kotlinx.lincheck.runner.ParallelThreadsRunner.close([ParallelThreadsRunner.kt:339](http://www.docjar.com/html/api/org/jetbrains/kotlinx/lincheck/runner/ParallelThreadsRunner.kt.html))
    at kotlin.io.CloseableKt.closeFinally(Closeable.kt:56)
    at org.jetbrains.kotlinx.lincheck.strategy.stress.StressStrategy.run([StressStrategy.kt:67](http://www.docjar.com/html/api/org/jetbrains/kotlinx/lincheck/strategy/stress/StressStrategy.kt.html))
    at org.jetbrains.kotlinx.lincheck.LinChecker.run([LinChecker.kt:152](http://www.docjar.com/html/api/org/jetbrains/kotlinx/lincheck/LinChecker.kt.html))
    at org.jetbrains.kotlinx.lincheck.LinChecker.checkImpl([LinChecker.kt:87](http://www.docjar.com/html/api/org/jetbrains/kotlinx/lincheck/LinChecker.kt.html))
    at org.jetbrains.kotlinx.lincheck.LinChecker.checkImpl$third_party_java_kotlinx_lincheck_kotlinx_lincheck([LinChecker.kt:59](http://www.docjar.com/html/api/org/jetbrains/kotlinx/lincheck/LinChecker.kt.html))
    at org.jetbrains.kotlinx.lincheck.LinCheckerKt.checkImpl([LinChecker.kt:233](http://www.docjar.com/html/api/org/jetbrains/kotlinx/lincheck/LinChecker.kt.html))
    at org.jetbrains.kotlinx.lincheck.test.AbstractLincheckTest.runInternalTest([AbstractLincheckTest.kt:40](http://www.docjar.com/html/api/org/jetbrains/kotlinx/lincheck/test/AbstractLincheckTest.kt.html))
    at org.jetbrains.kotlinx.lincheck.test.AbstractLincheckTest.testWithStressStrategy([AbstractLincheckTest.kt:57](http://www.docjar.com/html/api/org/jetbrains/kotlinx/lincheck/test/AbstractLincheckTest.kt.html))

For now, we're just patching out the call. That doesn't appear to cause any issues for our runs of Lincheck's own tests (including under JDK 11), though I assume it could cause problems if people really did need the threads to exit.

An intermediate option would be to call stop but to catch the UnsupportedOperationException.

I haven't looked at whether interrupting the threads is likely to be of any use. I assume that you'd already be doing it if it were a general solution, so it's probably just a question of whether it's better than nothing.

ndkoval commented 5 months ago

Fixed under #271. Please proceed with the recent Lincheck 2.25 release.