search

JetBrains / meta-runner-power-pack

A set of Meta-runners for TeamCity
Apache License 2.0
257 stars 125 forks source link

Gerrit Metarunner always vote +1 #10

Open K2DaC opened 11 years ago

K2DaC commented 11 years ago

The Gerrit Metarunner always votes +1, verified, even if the build fails?

Expected: If the Build is failing, -1 is voted!

nd commented 11 years ago

Cannot reproduce that.. What is your build configuration setup?

K2DaC commented 11 years ago

We are using TeamCity 8.0.2 and Gerrit 2.5.2. The Build is done with ANT. (Android App)

[16:00:40][Ant output] BUILD FAILED .... [16:00:42][echo] ##teamcity[setParameter name='system.gerrit.verification.successful' value='true']

and then TeamCity is marking the Build as "success".

The Build has like 6 Steps, and gerrit verification is tha last one with "run always" setting.

I'll investigate some more time, but i cannot find any condition in the meta-runner which will flag the build as FAIL

nd commented 11 years ago

I think I have fixed that (d2a0f40ce50ffac487373b93289b1d042a49684c). Please update the runner, let me know if it helps.

Also you might be interested in Commit Status Publisher, it provides a Gerrit changes verification as a build feature.

K2DaC commented 11 years ago

I'Ve changed that value in my configuration, but it's still posting : +1: Patch Set 1: Verified Build successful

if the Build failed.

Our iOS Team is using https://github.com/maxifier/teamcity-gerrit-plugin and they are fine (the have a "silet-default-branch") which is never build. But i want to avoid to have this. Maybe jetbrains will finaly make the "default" branch optional, then this plugin would be fine, but currently i'd like to use the meta runners. But if they always flag the build as successful, it makes no sense.

Our Current Workaround: The last Build-Step (Gerrit Meta-Runner) is only triggerd if all other steps have been successful. This means you have ether +1 or no comment at all.