search

JetBrains / plugin-repository-rest-client

Apache License 2.0
21 stars 15 forks source link

Updates and fixes #18

Closed satamas closed 6 years ago

satamas commented 6 years ago

Plugin repository returns 302 code but now its handled by UrlConnection. That feature was turned off before and I don't understand why. Probably that was done because that handling not worked well with redirect from http to https. I've made all those changes after problem that we met a week ago when we replaced absolute redirects on our side with relative ones. Current code has no support for such redirects.

chashnikov commented 6 years ago

Ok, I've merged the first two commits to 'master' (with more detailed commits messages), will look at the other commits a bit later.

chashnikov commented 6 years ago

Ok, I've rearranged your commits, updated commits messages and pushed them to 'master'. Thank you for the contribution!

In the future please commit unrelated changes in different commits and related changes in same commits (here the actual change was split between two commits and mixed with cleanups and other changes) and provide more detailed commits messages (describe not only what you did but also why you did it). It'll simplify reviewing commits and exploring the project history.