search

JetBrains / plugin-repository-rest-client

Apache License 2.0
21 stars 15 forks source link

Use hub permanent token instead of username/password parameters #22

Closed satamas closed 6 years ago

satamas commented 6 years ago

Plugin repository now supports Hub permanent tokens for command line clients authentication. With this support useranme/pasword authentication becomes deprecated.

chashnikov commented 6 years ago

Why not keep the old way for compatibility?

satamas commented 6 years ago

1) We want to enforce users to use tokens in order to be able to drop username/passoword support on server side. 2) As far as I understand, in most cases user will have to explicitly update library/plugin version to get those changes, which means that nothing will be broken unexpectidly.

chashnikov commented 6 years ago
  1. Dropping support in the new version of the client won't help you dropping support on server side because users may still use the old version of the client.
  2. Yes, but it's means that after updating the library users will get compilation errors without any evident way to fix them. It would be much more convenient if after updating the library they'll see that method become deprecated with explanation what should be used instead. This way you help users to update to the new scheme, not force them, and I think it'll make them update faster and therefore help you with item 1. Also note that an older version of this library may be used as a transitive dependency for other libraries in user's project, and updating it may cause version conflicts.
chashnikov commented 6 years ago

Merged to master, thank you!