search

JetBrains / pty4j

Pty for Java
Eclipse Public License 1.0
356 stars 112 forks source link

Test Results while attempting to add OpenBSD support #97

Open nicholasburn opened 3 years ago

nicholasburn commented 3 years ago

The tests are a little unstable, sometimes they pass, sometimes they don't. I've tried both from the system terminal and from inside intellij. Here is the summary for my last run from Intellij:

test -> 18 passed, 4 ignored testjar -> 17 passes, 4 ignored, 1 failed (testInitialColumnsAndRows)

Is this okay for making a pull request or do all of them have to work? Also is anyone else trying to do the same at the moment?

I've made a few edits to the code that you can find here https://github.com/nicholasburn/pty4j/tree/devel The last commit contains the binaries, the second last contains the code.

The binaries are a new version of purejavacomm (from here https://github.com/nicholasburn/purejavacomm and I've added a pull request on the main repo from which i've forked) and the libpty.so that i've compiled.

Please let me know! I would really like to get that terminal plugin to work

segrey commented 3 years ago

Thanks for adding OpenBSD support. Unfortunately, I don't have OpenBSD instance now, so can't help much here. The tests are stable for me on Linux/macOS. We need to make them passing or identify the problem in test and fix it. Let's wait for adding OpenBSD in purejavacomm and update pty4j to use it once it's available.