JetBrains / resharper-fsharp

F# support in JetBrains Rider
Apache License 2.0
327 stars 54 forks source link

Instructions to build the `ReSharper.FSharp` solution are insufficient #565

Closed nathanpovo closed 1 year ago

nathanpovo commented 1 year ago

The instructions in the README for building the solution are insufficient; it is not possible to build the solution without errors.

https://github.com/JetBrains/resharper-fsharp/blob/4f0754710a9dcfd3bb8e84c1fc0a59353b9e33e9/README.md?plain=1#L39

The MSBuild version is using the dotnet version:

image

As soon as I hit "build", I am getting errors throughout the solution (mostly missing namespaces)

image

image

image

Tested with commit https://github.com/JetBrains/resharper-fsharp/commit/4f0754710a9dcfd3bb8e84c1fc0a59353b9e33e9 on the main branch

auduchinok commented 1 year ago

@nathanpovo It looks like the references to R#/Rider SDK are missing. Did prepare task from the instructions complete successfully?

We've also had some issues with build due to some internal infrastructure work. I've merged the recent fixes into main, could you try it once more, please?

nathanpovo commented 1 year ago

@nathanpovo It looks like the references to R#/Rider SDK are missing. Did prepare task from the instructions complete successfully?

What "prepare" task are you refferring to?

I am getting stuck the second step of this section https://github.com/JetBrains/resharper-fsharp/blob/4f0754710a9dcfd3bb8e84c1fc0a59353b9e33e9/README.md#building-the-plugin-and-launching-rider-in-a-sandbox

We've also had some issues with build due to some internal infrastructure work. I've merged the recent fixes into main, could you try it once more, please?

Same issue

image

image

auduchinok commented 1 year ago

What "prepare" task are you refferring to?

The one in the first step of this section https://github.com/JetBrains/resharper-fsharp/blob/4f0754710a9dcfd3bb8e84c1fc0a59353b9e33e9/README.md#building-the-plugin-and-launching-rider-in-a-sandbox.

nathanpovo commented 1 year ago

It worked.

I don't know how I completely missed that step 🤦

Thank you for taking the time to help and apologies for any time wasted.

nathanpovo commented 1 year ago

For anyone that stumbles on this ticket, make sure you do not skip this step

image