search

JetBrains / resharper-fsharp

F# support in JetBrains Rider
Apache License 2.0
327 stars 53 forks source link

Override rule #590

Closed nojaf closed 7 months ago

nojaf commented 8 months ago

@dawedawe in the last couple of commits I'm looking for the last type member above the cursor. I believe you did something similar a while ago. Does anything come to mind if I can reuse some logic?

dawedawe commented 8 months ago

@dawedawe in the last couple of commits I'm looking for the last type member above the cursor. I believe you did something similar a while ago. Does anything come to mind if I can reuse some logic?

Your approach seems fine to me. I also just tryLast ed on TypeMembersEnumerable and friends, see here. But nothing reusable for you, I think.

auduchinok commented 7 months ago

@nojaf Thanks for the initial prototype you've made! It helped to test various cases and the tests helped here as well. I've updated various things and merged it in.

nojaf commented 7 months ago

Thank you for picking this up! I'm really happy with the result here!