JetBrains / resharper-rider-samples

Simple interactive exercises to help learn ReSharper and Rider
Apache License 2.0
228 stars 172 forks source link

Proposal for creating a Japanese localized version #20

Open sun-flat-yamada opened 3 years ago

sun-flat-yamada commented 3 years ago

Nice to meet you. And thank you for the great sample.

I am in awe of JetBrains' tools, they are really well done. I want my colleagues to get more familiar with this tool, so I am conducting my own Hands on.

I'm teaching it while translating it into Japanese, and I'd be happy to contribute step by step, and I'd like to send out a PR when I make a localized version in Japanese.

So I would like to discuss the directory structure of the Japanese localized version.

I think it would be better to have separate repositories, would the following structure be ok?

ex.

JetBrains
 `- resharper-rider-samples (current english version)
 `- resharper-rider-samples-ja (japanese localized version)

Best regards.

maartenba commented 3 years ago

Hi @sun-flat-yamada ! First of all, thank you for stepping up with this proposal. It's really something we would like to see, so thank you in advance for this.

I'd like us to try subdirectories in the current repository (en and ja, for example), and then a README that explains in both languages where to find localized resources.

If you want, I can make a commit to make these base changes?

sun-flat-yamada commented 3 years ago

Thank you for your quick reply @maartenba .

I think your suggestion is fine. However, if it could be improved more, I think it would be better to create a intermediate directory like a 'localized'.

My understanding of your proposal is as follow:

resharper-rider-samples
  `- :
  `- 11-Other
  `- .gitattributes
  `- :
  `- en
  `- :
  `- ja
  `- :
  `- :

And the proposal I described above is below:

resharper-rider-samples
  `- :
  `- 11-Other
  `- localized (This naming is just an idea...)
    `- en (Is this redundant? The official (master) ver is already available in en.)
    `- :
    `- ja
    `- :
    `- :
  `- .gitattributes
  `- :

What do you think?

If you can make a subdirectory for localization, I would like the 1st commit to include the current English version. I will try to publish PRs in the order of the translated ones.

maartenba commented 3 years ago

That's a good idea actually. I made a commit that adds the localized folder, and added ja in there. Not sure about the kanji I used in the localized/README.md, but I trust you will correct it if needed :-)

You can copy everything in the localized/ja folder. Does that work for you?

sun-flat-yamada commented 3 years ago

Thanks for the quick response. @maartenba

The preparation you have done is good. The Japanese Kanji you wrote is also perfect.

When I start working on it, I'll 1st commit the latest en version at that time and send out a PR.

Thanks.