search

JetBrains / rider-theme-pack

JetBrains Rider theme pack.
Apache License 2.0
26 stars 9 forks source link

Rider Dark Theme is mixed with Light theme #19

Closed eyalist closed 8 months ago

eyalist commented 1 year ago

After upgrading IntelliJ (and other IDEs like WebStorm), the rider dark theme is mixed with the light one - Some UI elements are dark but the editor section is light:

bug

Tested on:

pkropachev commented 1 year ago

I have the same problem.

pkrakowiak commented 1 year ago

There's an opposite problem, too, where on Rider Day some elements display black backgrounds which makes them illegible.

obraz

obraz

orest-tokovenko-deel commented 1 year ago
Screenshot 2023-09-26 at 10 44 52 AM

I'm also having this problem in DataGrip 2023.2.1 after upgrading to Rider UI Theme Pack 0.14.3

@homatyano can you kindly roll back the last update? There are breaking changes

EDIT: I manually installed 0.14.2 but the bug persists... Not sure what's causing it

pkropachev commented 1 year ago

The following workaround helped me solve the problem on my side (IDEA 232.9921.47, built on September 13, 2023, Rider UI Theme Pack 0.14.3).

After change the theme, go to File | Settings | Editor | Color Scheme and change scheme to the same that specified in Appearance | Theme.

rider-theme

orest-tokovenko-deel commented 1 year ago

Update: Using Rider Night rather than Rider Dark theme seems to have fixed the issue

homatyano commented 1 year ago

Since recently, IDEA remembers which editor color scheme was last selected for a particular UI theme. So the next time that UI theme is selected, instead of the editor scheme specified by the UI theme, the user preferred editor scheme is loaded instead.

Unfortunately, during the transitional period this caused a number of cases where a wrong editor scheme was selected by the IDE. Meaning, there's nothing wrong with the UI theme or editor scheme, it's just the user preferences were not correctly preserved.

Please report if it still happens for you.

drusellers commented 10 months ago

Just hit this again today. Ugh.

real-zony commented 9 months ago

I encountered this bug again. 😭

martin-hirsch commented 8 months ago

Same here <3

Rider 2023.3.3 macOS Restarting Rider is a workaround

homatyano commented 8 months ago

Thanks for taking the time to report the issues. It seems the underlying issue was finally resolved:

https://youtrack.jetbrains.com/issue/RIDER-106580/Errors-while-changing-IDE-theme-in-Rider#focus=Change-27-9386814.0-0

martin-hirsch commented 8 months ago

@homatyano, thanks for clarifying! :-) The link seems broken? aka. "Nope, can't find it!"

homatyano commented 8 months ago

@martin-hirsch Sorry I didn't notice the issue was assigned a limited visibility because it contains some private details.

Regarding the issue, the IDE remembers which color scheme was last used with a particular UI theme. Thus, the incorrect scheme will be selected again each time the theme is selected, even though it was selected because of an error in the first place.