search

JetBrains / sbt-tc-logger

SBT plugin generates TeamCity service messages to be used by SBT runner
Apache License 2.0
10 stars 12 forks source link

Don't hide test failures #13

Closed alexduf closed 3 years ago

alexduf commented 7 years ago

This is an attempt to solve the issue of a non-blocking failing test.

We (the Guardian) have encountered issues when using the embedded version of sbt. The observed behaviour is that in the case of a test failure the build process continues and produce an artefact. The expected behaviour would be to stop on test failure.

This has been documented at least here, here and here.

I have found that ticket describing what were these lines supposed to do in the first place, but the ticket doesn't explain why it should.

Since I can't find a good justification, and given the potential production issues the current version can cause, I am rising the current PR in the hope it will be merged and released.

I successfully tested the change using @jsancio 's repo but didn't push the change to teamcity to test it in situ as it's not the most obvious set-up to make.

Please let me know if I missed anything obvious and if there's a good reason to hide "Process exited with code 1" as I don't know teamcity very well.

Thanks for your help

amyhughes commented 6 years ago

@shkate we see you introduced the functionality this PR amends to fix the problem of failing tests not stopping the build process. Do you have any views on how these issues might be reconciled? https://youtrack.jetbrains.com/issue/TW-47698

Thanks!