search

JetBrains / skia-build

90 stars 45 forks source link

Adding Android Builds #4

Closed Danielku15 closed 3 years ago

Danielku15 commented 3 years ago

In preparation for having a Skija on Android (https://github.com/JetBrains/skija/issues/101) this PR adds Android builds to the toolchain. This PR includes:

I couldn't check the binaries yet so I trust that the Skia script handles the compilation well. Next step will be to extend Skija to target Android.

See latest compilation here: https://github.com/Danielku15/skia-build/actions/runs/680600460

nathanieloliveira commented 3 years ago

I can't belive I spent the last day working on basically the same thing 😂. I should have checked the open PRs section.

I'm hoping this gets merged. After implementing this myself, I've arrived at essentially the same implementation as you. My only doubt is: I can't point out when you download or install the Android NDK... Should we have a way to specify which version of the NDK to use? Thanks

Danielku15 commented 3 years ago

@nathanieloliveira NDK comes pre-shipped with the linux images of GitHub Actions: https://github.com/actions/virtual-environments/blob/ubuntu16/20210318.0/images/linux/Ubuntu1604-README.md

Currently by default it is pointing to 21.4.7075529. GitHub had some issues with the rollout of r22 in GitHub Actions. https://github.com/actions/virtual-environments/issues/2420

nathanieloliveira commented 3 years ago

@nathanieloliveira NDK comes pre-shipped with the linux images of GitHub Actions: https://github.com/actions/virtual-environments/blob/ubuntu16/20210318.0/images/linux/Ubuntu1604-README.md

Currently by default it is pointing to 21.4.7075529. GitHub had some issues with the rollout of r22 in GitHub Actions. actions/virtual-environments#2420

Interesting... In my attempt, I was downloading NDK-r22 from google repos and using ubuntu latest image.

tonsky commented 3 years ago

Thank you! I’ll take a look soon

tonsky commented 3 years ago

Seems to work! https://github.com/JetBrains/skia-build/actions/runs/690480166. Merged as efb641ac5574b2c7d55dd84511deb53e9ed4cc7a. Thank you!