Bugfix: Also check if require.main.require is not undefined to fix PhpStorm coding assistance

JetBrains / svg-sprite-loader

Webpack loader for creating SVG sprites.

MIT License

2.02k stars 270 forks source link

Bugfix: Also check if require.main.require is not undefined to fix PhpStorm coding assistance #382

Closed xidb closed 4 years ago

xidb commented 4 years ago

What kind of change does this PR introduce? (bugfix, feature, docs update, improvement) bugfix What is the current behavior? (You can also link to an open issue here) ESLint code assistance is not working in PhpStorm What is the new behavior (if this is a feature change)? ESLint code assistance is working in PhpStorm Does this PR introduce a breaking change? No Please check if the PR fulfills contributing guidelines

719media commented 4 years ago

This PR also addresses issues with vscode eslint (see #381)

kisenka commented 4 years ago

@xidb I've dropped webpack detecting in svg-sprite-loader@4.2.6, so this PR is no longer actual. But thanks for your contribution anyway :)