search

JetBrains / svg-sprite-loader

Webpack loader for creating SVG sprites.
MIT License
2.02k stars 270 forks source link

fix: conflict of nodejs version #404

Closed mayako21126 closed 3 years ago

mayako21126 commented 4 years ago

fix: conflict of nodejs version

fix: eslint bug https://github.com/eslint/eslint/issues/13352

What kind of change does this PR introduce? (bugfix, feature, docs update, improvement) bugfix What is the current behavior? (You can also link to an open issue here) 1 update eslint7 caused some error (pr build failed) 2 eslint7 have a bug in travis https://github.com/eslint/eslint/issues/13352 What is the new behavior (if this is a feature change)? will use shell script to build(in scripts/build.sh) webpack1-3 use nodejs 8.10.0 & webpack4-5 use nodejs 12.0.0 Does this PR introduce a breaking change? no Please check if the PR fulfills contributing guidelines ok

d3x42 commented 3 years ago

@mayako21126 Please resolve conflicts and I'll merge this PR

mayako21126 commented 3 years ago

@mayako21126 Please resolve conflicts and I'll merge this PR https://github.com/JetBrains/svg-sprite-loader/pull/403 includes this PR