search

JetBrains / teamcity-azure-active-directory

TeamCity plugin which supports authentication via Microsoft Azure Active Directory
Apache License 2.0
26 stars 19 forks source link

Allow bearer token authentication #23

Open Xeloss opened 7 years ago

Xeloss commented 7 years ago

Added support for bearer token authentication for HTTP requests to the TeamCity's API The plugin extracts the claims "OID" or "AppID" from the bearer token present in the "Authorization" header of the requests, and tries to match them against the user's email field (which must contain the "OID" or the "AppID" of the service principal associated with that user).

ghost commented 7 years ago

@Xeloss, thank you for the PR with valuable feature implemented, To accept it I should ask you to make few improvements.

  1. Please follow used codestyle. We use intellij coding guidelines http://www.jetbrains.org/display/IJOS/IntelliJ+Coding+Guidelines
  2. Please make sure you've handle all possible NPE's
  3. This PR contains another PR with login page customization which I've commented earlier https://github.com/ekoshkin/teamcity-azure-active-directory/pull/21#issuecomment-276504498 Please separate these PR's.