JetBrains / teamcity-deployer-plugin

Deployer plugin for TeamCity CI server
http://confluence.jetbrains.net/display/TW/Deployer+plugin
Apache License 2.0
39 stars 29 forks source link

Periods not supported in smb deployer path #19

Closed nskvortsov closed 9 years ago

nskvortsov commented 9 years ago

See http://stackoverflow.com/questions/62771/how-check-if-given-string-is-legal-allowed-file-name-under-windows for a discussion of this.

Periods are not listed under the invalid set of characters to be in a path. In practice, my company has several shares with folders with periods in the name (particularly when deploying to websites). However, a regex in SmbDeployerRunType.java called SIMPLE_UNC_REGEX does not allow for periods anywhere in the target URL. This prevents us from using SMB deployment for placing files on our web server.

I'm running build: snapshot-20130208170029


nskvortsov commented 9 years ago

This issue prevents you from using parameters as well ex. env.{parameter}


Original comment by: Dan Nash

nskvortsov commented 9 years ago

Fixed by https://bitbucket.org/nskvortsov/deployer/pull-request/7/fix-for-issue-19-allow-dots-in-unc-path/diff

Thanks to @redoz


Original comment by: Nikita Skvortsov