JetBrains / teamcity-deployer-plugin

Deployer plugin for TeamCity CI server
http://confluence.jetbrains.net/display/TW/Deployer+plugin
Apache License 2.0
39 stars 29 forks source link

FTP Deploy Speed Slow #55

Closed jhelmink closed 9 years ago

jhelmink commented 9 years ago

Hey, so firstly I'd just like to say thanks for this plugin! I use it to deploy all of my projects to various servers via FTP. I've read through some of the other issues here and I'd like to share my experiences. I deploy via regular FTP using normal credentials to an IP address. Using FTP deployer I can deploy a build of ~1000 files totaling ~25Mb from an NZ server to a UK server in about 2 hours. However if I use FileZilla for a manual deployment (overwriting all files) between the same servers it only takes about 20 minutes.

jhelmink commented 9 years ago

One thing to add to this, the main reason that this is a problem is that the build will fail 25% of the time with a "java.net.SocketTimeoutException: Read timed out" error which means a lot of lost time to re-run the build.

alefr commented 9 years ago

I'm seeing the same behavior when trying to deploy from an azure vps to an azure website both with North European storage. Running the FTP upload manually from the vps is no problem but from the deployer takes a really long time and eventuell fails with a "java.net.SocketTimeoutException: Read timed out".

jhelmink commented 9 years ago

@alefr contact me privately contact@joshhelmink.com for an interim alternative solution.

wedocodeuk commented 9 years ago

I have the same problem, it appears to only open a single thread, and only uploads a single file at a time. I am considering uploading and ZIP and then setting up ssh and unzipping via that.

vladkosarev commented 9 years ago

About every other time we get java.net.SocketTimeoutException: Read timed out during upload to Azure ftp build step.

nskvortsov commented 9 years ago

Please try this build of the plugin. Happy deploying!

vladkosarev commented 9 years ago

Updated the plugin now just get - java.lang.NullPointerException all the time

nskvortsov commented 9 years ago

@vladkosarev please attach a stacktrace

vladkosarev commented 9 years ago

@nskvortsov Where can I see full exception?

I just get this in the log - [12:54:43][Step 8/9] Exception while uploading files: null [12:54:43][Step 8/9] java.lang.NullPointerException [12:54:43][Step 8/9] Step Deploy to FTP (FTP Deployer) failed

Nothing in any of the logs on the server either.

nskvortsov commented 9 years ago

Take a look at teamcity-agent.log under logs directory. Also, enabling agent debug logging can help. 2 нояб. 2015 г. 23:11 пользователь "Vlad Kosarev" notifications@github.com написал:

@nskvortsov https://github.com/nskvortsov Where can I see full exception?

I just get this in the log - [12:54:43][Step 8/9] Exception while uploading files: null [12:54:43][Step 8/9] java.lang.NullPointerException [12:54:43][Step 8/9] Step Deploy to FTP (FTP Deployer) failed

Nothing in any of the logs on the server either.

— Reply to this email directly or view it on GitHub https://github.com/JetBrains/teamcity-deployer-plugin/issues/55#issuecomment-153143227 .

vladkosarev commented 9 years ago

Found it - Caused by: java.lang.NullPointerException at jetbrains.buildServer.deployer.agent.ftp.FtpBuildProcessAdapter.dirExists(FtpBuildProcessAdapter.java:386) at jetbrains.buildServer.deployer.agent.ftp.FtpBuildProcessAdapter.createPath(FtpBuildProcessAdapter.java:358) at jetbrains.buildServer.deployer.agent.ftp.FtpBuildProcessAdapter.access$400(FtpBuildProcessAdapter.java:32) at jetbrains.buildServer.deployer.agent.ftp.FtpBuildProcessAdapter$1.run(FtpBuildProcessAdapter.java:221) ... 1 more

vladkosarev commented 9 years ago

Could it be that newer versions don't support UNC paths?

p.s. tried non-unc path and the same error

vladkosarev commented 8 years ago

Installed newest TeamCity and whatever the latest build was on plugins page, reinstalled agents. Same issue. Is there a page with older versions I can try out? At this point all our deployment builds are broken due to this issue.

nskvortsov commented 8 years ago

@vladkosarev here is an older version of plugin: http://teamcity.jetbrains.com/guestAuth/repository/download/bt402/619410:id/deploy-runner.zip?guest=1 Also, I have opened a new issue for the NPE https://github.com/JetBrains/teamcity-deployer-plugin/issues/68