search

JetBrains / teamcity-docker-agent

TeamCity agent docker image sources
https://hub.docker.com/r/jetbrains/teamcity-agent/
Apache License 2.0
77 stars 64 forks source link

Update docker-engine #12

Closed lorddaedra closed 6 years ago

lorddaedra commented 6 years ago

Please, update Docker. Your current version is outdated (little) and doesn't support commands like cat /data/teamcity_agent/conf/gcloud.service-key | docker login -u _json_key --password-stdin https://gcr.io

lorddaedra commented 6 years ago

( --password-stdin )

lorddaedra commented 6 years ago

@shkate I see, you are maintainer of Dockerfile, can you update Docker from 17.06.0~ce-0~ubuntu to 17.12.0~ce-0~ubuntu, please? Looks like it's latest version of Docker, available to Ubuntu LTS.

Here https://github.com/JetBrains/teamcity-docker-agent/blob/master/ubuntu/Dockerfile#L21

mykolapolonskyi commented 6 years ago

this issue https://github.com/docker/for-mac/issues/1827 also can be additional reason to update the 17.06.0-ce (have catch it when set up teamcity and trying integrate in with local docker registry)

VladRassokhin commented 6 years ago

Hopefully would be in 2017.2.2

johnkors commented 6 years ago

@VladRassokhin I couldn´t really find in YouTrack whether this was resolved in a release. Has the engine been updated lately?

VladRassokhin commented 6 years ago

@johnkors Last update was in March https://github.com/JetBrains/teamcity-docker-agent/commit/f4010b1bae9658890b0a37e527743e062c4058be