JetBrains / teamcity-google-agent

TeamCity support for Google cloud build agents
Apache License 2.0
17 stars 9 forks source link

Add support for specifying GCP Source project for images/image families #44

Closed fatmcgav closed 3 years ago

fatmcgav commented 4 years ago

Add support for launching agents using images from a different project.

This can be useful if images are in a different project to that which the agents are being launched in.

Set a 500ms timeout on the Source Project input to ensure that not refreshing images on every key press.

Closes #41

N.B: This builds on #42, so will need to merge that one first. The relevant commit that adds this functionality is db5c8e6 (#44)

fatmcgav commented 4 years ago

I recorded another gif of this one in action:

TC-ImagesFromOtherProject

fatmcgav commented 4 years ago

So whilst testing this a bit more, we spotted an issue with launching instances based on images in the same project, so fixed that in 4b4bdde (#44)

fatmcgav commented 4 years ago

@dimyriy This one is ready for a review now aswell :)

undimmable commented 3 years ago

Thank you very much for your contribution!

fatmcgav commented 3 years ago

Thanks for merging @dimyriy .

Is it possible to get a new release of this plugin that incorporates the recent changes?

undimmable commented 3 years ago

Thanks for merging @dimyriy .

Is it possible to get a new release of this plugin that incorporates the recent changes?

Sure, https://teamcity.jetbrains.com/buildConfiguration/TeamCityGoogleCloudAgent_Build/3225600

fatmcgav commented 3 years ago

Thanks for merging @dimyriy . Is it possible to get a new release of this plugin that incorporates the recent changes?

Sure, teamcity.jetbrains.com/buildConfiguration/TeamCityGoogleCloudAgent_Build/3225600

Great, thanks for that.

Should the version bump and tags happen in due course?

undimmable commented 3 years ago

Here you go, it's the 0.8.0 version. Thank you again for contributing to the TeamCity!

fatmcgav commented 3 years ago

Awesome, thanks @dimyriy

I suspect there'll be a couple more features coming soon... 😎