search

JetBrains / teamcity-messages

Python Unit Test Reporting to TeamCity
https://pypi.python.org/pypi/teamcity-messages
Apache License 2.0
138 stars 81 forks source link

Fix teamcity-messages for pylint >= 2.8 #242

Closed Tirzono closed 3 years ago

Tirzono commented 3 years ago

Pylint made changes so pylint.__pkginfo__.version does not exist anymore and can be accessed now by pylint.__pkginfo__.__version__. This PR makes sure it works for both pylint >= 2.8 and pylint < 2.8.

Related to PyCQA/pylint#4399

Tirzono commented 3 years ago

The build is failing but I don't think this is an issue with the change I made, but rather with the fact that it's been a while that we've run tests for teamcity-messages and some thing got broken over time.

kolibri91 commented 3 years ago

Can you please tell me in which version this fix will be released?

Tirzono commented 3 years ago

@mikekidya @throwable-one @madlexa would you be willing to have a look at this one? :)

esztermarton commented 3 years ago

Nice change! Here's the commit that caused this. Would be great to have a new version of tc messages with this!

mikekidya commented 3 years ago

Sorry for the delay and thank you for the PR, changes look cool to me. According to JetBrains policies we can only accept PRs from contributors who signed JetBrains CLA. Could you please consider signing it?

Tirzono commented 3 years ago

Hi @mikekidya,

Thank you for your reply. I signed the JetBrains CLA. Please let me know if anything else is needed.

Tirzono commented 3 years ago

Hi @mikekidya,

Would it be possible to do a new release so I can update pylint again?