Misleading message 'could not clean output directory' with multiple steps, and clean disabled

JetBrains / teamcity-nuget-support

TeamCity NuGet support

Apache License 2.0

43 stars 11 forks source link

Misleading message 'could not clean output directory' with multiple steps, and clean disabled #14

Closed matt-richardson closed 8 years ago

matt-richardson commented 8 years ago

We have a build that has three nuget pack steps in it, with the "clean output directory" set to false.

On the second and third steps, it misleadingly states "Could not clean output directory, there were another NuGet Packages Pack runner with disabled clean".

it appears that the interaction between OutputDirectoryCleanerProcess.java and PackRunnerOutputDirectoryTrackerImpl.java misses the case when both the first and subsequent steps have the clean flag disabled.

ghost commented 8 years ago

@matt-richardson thank for this request, its defiantly a bug. Feel free to compose a pull request with a fix. I'll get back to this issue a bit later.

matt-richardson commented 8 years ago

Hi @ekoshkin - I've already submitted a pull request - https://github.com/JetBrains/teamcity-nuget-support/pull/15 - is it not showing up?

ghost commented 8 years ago

@matt-richardson now i see it, thank for that

ghost commented 8 years ago

fixed in 0c8f91119e89c0e2575c2353dade82ce88832745