search

JetStreamVelocity / jetstreamvelocity.github.io

Other
0 stars 0 forks source link

Alter font size and family of some styles #3

Open JetStreamVelocity opened 7 years ago

JetStreamVelocity commented 7 years ago

From what I can gather SCSS generates styles with font sizes in specific increments in this theme.

May need to break that to allow specific configuration of font-family and font-size of some some styles.

To start with, could do with smaller font-size for \<h1> and \<h2>

TracyGJG commented 7 years ago

The font-sizes are set in the layout.scss file but only for those h1-h4 inside a .post-content element, set to 38, 32, 26 and 20px respectively. Using px is a poor choice for font-sizes and we/you would be better using em (1em = 12pt = 16px). Also the .sidebar-module class sets an h4 to font-size of $base-font-size, which is set in main.scss as $base-font-size: 16px; I do not see anywhere else they could be set by scss/sass. I suggest changing the H1-4 sizes to 2em, 1.75em, 1.5em, and 1.25em (32, 28, 24, 20px.)

TracyGJG commented 7 years ago

I have provided PR #4 as a possible approach.

JetStreamVelocity commented 7 years ago

Thanks for the PR #4 @TracyGJG

After seeing your comment yesterday, I dug into the code again and spotted what you were referring to .. indeed the sizes were being set statically in _sass/_layout.scss.

This is good. I'll merge these in.

TracyGJG commented 7 years ago

I think the PR sizes might be a little larger than your recent change but we can revise that later. We should be using the $base-font-size variable as a base multiplier.

I suggest you don’t close the issue just yet.