search

JetpackDuba / Gitnuro

A FOSS Git multiplatform client for newbies and pros
https://gitnuro.com/
GNU General Public License v3.0
946 stars 46 forks source link

Compact view #128

Open MetalArend opened 1 year ago

MetalArend commented 1 year ago

First time using Gitnuro, and wow, amazing work! I'm not sure if I should create separate feature requests, but here are some things that would be nice to have, some day ;)

JetpackDuba commented 1 year ago

Hey! Thanks for your interest :smile:

Some points are interesting but other are most likely a won't do. Here we go:

First time using Gitnuro, and wow, amazing work! I'm not sure if I should create separate feature requests, but here are some things that would be nice to have, some day ;)

* A more compact view

  * Settings to change the font size, the line-height
  * Setting to change the size of the profile pictures in the graph, so things can be smaller, and the commit row height can be smaller

I agree about having a more "compact" view with the graph and I will probaby add one in the future, but not for the rest of the app (perhaps in specific views but not in general), since I don't think there is much benefit to it but increases the maintenance complexity.

The exception would be the fonts, which may be somewhat customizable but I'm not exactly sure how right now. Probably a mix between font family and some specific font sizes but I can't promise anything for now.

* Option to keep the commit history pane visible when showing the diff pane

In what use case would that be helpful?

* Option to show the staged/unstaged in one pane

In what use case would that be helpful? Seems just like a visual change, because the vertical height taken from having them split it's minimal.

* Option to show the files in a tree structure

Already tracked in #22 

* A pane to switch between different repositories

I think you mean something like #49. That's a won't fix, but I'm working on giving a different alternative which would cover most cases.

MetalArend commented 1 year ago

I agree about having a more "compact" view with the graph and I will probaby add one in the future, but not for the rest of the app (perhaps in specific views but not in general), since I don't think there is much benefit to it but increases the maintenance complexity. The exception would be the fonts, which may be somewhat customizable but I'm not exactly sure how right now. Probably a mix between font family and some specific font sizes but I can't promise anything for now.

Sorry, in hindsight I got it wrong when I tried to explain the more compact view. I looked at it again. The font-size and line-height is not really the problem. The thing is the space in between. Right now, even on full screen, I see only 21 commits in the history in one view. In a narrower view, there would be room to fit 42 commits in the same spot, without even changing the font-size, because there's a whole line of space between two lines. The same goes for the staged/unstaged panes, there is a lot of unused space, left, right, top and bottom. In CSS terms, I would be talking about the margin and padding that is - imo - too big, so things take up too much screenspace without showing much information. Use case for it: In a big project, with multiple branches going in and out, that's sometimes only showing me the last hour of commits for the team.

* Option to keep the commit history pane visible when showing the diff pane

In what use case would that be helpful?

Use case: quickly switching between commits, looking at changes, going from commit to commit, file to file. The need to click the close button to the right top corner to then seek the commit again I was just looking at, that's too much content switching from a UX perspective.

* Option to show the staged/unstaged in one pane

In what use case would that be helpful? Seems just like a visual change, because the vertical height taken from having them split it's minimal.

The combined pane will always be able to show double the information as the split version. On a full screen, I can only see 7 changed files on the split screen. With the more narrow ui, that would become 14, with the combined pane we get 28. So I could open Gitnuro on only a fourth of my screen to see the same amount of information. :)

Yes, 22 is indeed the same. And I commented on 49 with a use case. :)

JetpackDuba commented 1 year ago

Sorry, in hindsight I got it wrong when I tried to explain the more compact view. I looked at it again. The font-size and line-height is not really the problem. The thing is the space in between. Right now, even on full screen, I see only 21 commits in the history in one view. In a narrower view, there would be room to fit 42 commits in the same spot, without even changing the font-size, because there's a whole line of space between two lines. The same goes for the staged/unstaged panes, there is a lot of unused space, left, right, top and bottom. In CSS terms, I would be talking about the margin and padding that is - imo - too big, so things take up too much screenspace without showing much information. Use case for it: In a big project, with multiple branches going in and out, that's sometimes only showing me the last hour of commits for the team.

Oh yeah, it's exactly what I meant. I want also to give the option to hide other branches or show only the current branch in the graph, as it would also help understand the graph in such cases.

Use case: quickly switching between commits, looking at changes, going from commit to commit, file to file. The need to click the close button to the right top corner to then seek the commit again I was just looking at, that's too much content switching from a UX perspective.

Alright, can you open a new separate issue for it, please?

The combined pane will always be able to show double the information as the split version. On a full screen, I can only see 7 changed files on the split screen. With the more narrow ui, that would become 14, with the combined pane we get 28. So I could open Gitnuro on only a fourth of my screen to see the same amount of information. :)

Not really sure I'm following you, could you please do a quick drawing?