Add general fixes and optimizations to the project

JetradarMobile / android-snowfall

Fully customizable implementation of "Snowfall View" on Android.

Apache License 2.0

1.17k stars 173 forks source link

Add general fixes and optimizations to the project #24

Closed dniHze closed 3 years ago

dniHze commented 4 years ago

Change list:

Remove lazy accessors for fields. They are adding extra overhead in terms of memory and they are way too heavy for one threaded environment complex for Android world
Remove kotlin stdlib methods in onDraw. They are just adding extra allocations while trying to draw on Android canvas
Some code overall clean up
Migrate sample to AndroidX
Update dependencies for Kotlin and plugins

otopba commented 3 years ago

Any updates?

dniHze commented 3 years ago

Hi @otopba! I added this PR around a year ago and still didn't get any review and/or comments from the maintainer. Guess the project is kinda dead for now. 😞 But I would be extremely happy to see any updates for this PR.

johnkil commented 3 years ago

@dniHze you did a great job 👍