Closed 0x-jerry closed 1 year ago
Firstly, Thanks for your PR! In my opinion, the developer should keep this icon name unique when using the text scan strategy, so we should remind the developer in the readme.md, what's more, if the scan strategy can support function type, it will be wonderful!
Yes, using a functional type may be better. However, I believe we need to create another PR. Additionally, I prefer to keep this PR as simple as possible.
At some scenarios, we need to use config file to set icon instead of using
SvgIcon
directly.Another scenario is that we may need to wrap a component of
SvgIcon
to set some extra style and props.So I made an option
scanStrategy
to support these scenarios.BTW, Thank you for made this awesome plugin.