search

Jewelbots / arduino-library

This is the arduino library that works with the Jewelbots device
MIT License
20 stars 19 forks source link

Changed setLight from private to public #15

Closed aulvi closed 7 years ago

aulvi commented 7 years ago

I'd like to be able to use any RGB value on an LED but didn't see a way to do so w/the public API in the LED library. This is a teensy change to move the setLight function out of private scope.

Additionally, how do I test my work, build the firmware, etc? Any guidance here is welcomed, thanks!

SaraJo commented 7 years ago

here are some great ways to test: https://github.com/Jewelbots/arduino-library/wiki

testing your change locally and then will deploy.

SaraJo commented 7 years ago

Hi! This hasn't been forgotten, we are working on making this open without causing the animations to stop working as things need to be enabled and disabled. Stay tuned!

SaraJo commented 7 years ago

Okay, we opened it up on our end and are working on an easier way to push and test. Sorry to not incorporate your pull request, we are working on making this friendlier for developers. Thank you for your help.

aulvi commented 7 years ago

Not a problem, thanks for following up!