search

Jewelbots / arduino-library

This is the arduino library that works with the Jewelbots device
MIT License
20 stars 19 forks source link

Example from the main readme fails to compile #20

Closed zosnap closed 7 years ago

zosnap commented 7 years ago

The "hello world" sketch on the main readme fails to compile with the error "'class LED' has no member named 'on'". The example at https://github.com/Jewelbots/arduino-library/blob/master/jewelbots_nRF51822_board_v100/Examples/JWB_blank/JWB_blank.ino does compile, so either that should get moved up to the main page, or the existing example should be updated to reference turn_on_all or some other method that exists.

glennblock commented 7 years ago

Thanks Zoe! If you'd like you can send us a PR, otherwise someone will fix. On Tue, Dec 27, 2016 at 10:16 PM Zoe Snape notifications@github.com wrote:

The "hello world" sketch on the main readme fails to compile with the error "'class LED' has no member named 'on'". The example at https://github.com/Jewelbots/arduino-library/blob/master/jewelbots_nRF51822_board_v100/Examples/JWB_blank/JWB_blank.ino does compile, so either that should get moved up to the main page, or the existing example should be updated to reference turn_on_all or some other method that exists.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Jewelbots/arduino-library/issues/20, or mute the thread https://github.com/notifications/unsubscribe-auth/AAInRIfrmfWIFskmvPX3KxuxUrw-3irXks5rMf7VgaJpZM4LWsuE .

davison-sm commented 7 years ago

Thanks, merged the pull request to update the example.