search

Jewelbots / ng-cordova-bluetoothle

Angular 1.x wrapper for the PhoneGap/Cordova Bluetooth Low Energy Plugin
Other
14 stars 43 forks source link

Multiple success callbacks #1

Closed randdusing closed 8 years ago

randdusing commented 9 years ago

Mostly made improvements to multiple success callbacks and created a demo.

gortok commented 9 years ago

Can you squash these commits using rebase -i? It's hard to follow what's going on with so many commits. From what I see so far, I like what you did.

randdusing commented 9 years ago

I did the rebase, but tt still looks like a mess since I removed node_modules. I figure you can just npm install. Should I go ahead and remove the references to my branch? The homepage and bower install needs updating.

randdusing commented 8 years ago

Do you think we'll be able to merge this? I have some plugin updates coming soon, and would like to keep the Angular wrapper up to date as well.

gortok commented 8 years ago

There are merge conflicts. If you can clean up the commits and rebase off the current state of master I'd love to include these fixes.

randdusing commented 8 years ago

Ok, I'm going to close this one and will submit a new pull request when the plugin and wrapper are updated.