Jexinte
commented
1 year ago I closed it because I'm gonna rewrite that part and the user part together they have the same logic so I'm not totally sure of how it's gonna end but I found something interesting and should reduce the technical debt.
Even It's not a new feature and already create a branch for a new one for the article part I rather create a new branch for this refactor avoiding me to broke the entire project that way if I found that what I refactor is useless then I'll just deleted the new branch "refactor_login_and_form_homepage"(not created yet in few hours it will)
⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.
Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.
🔎 Detected hardcoded secrets in your pull request
| GitGuardian id | Secret | Commit | Filename | | | -------------- | ------------------------- | ---------------- | --------------- | -------------------- | | [7231695](https://dashboard.gitguardian.com/incidents/7231695?occurrence=100626491) | SMTP credentials | 5cecedffe752e91b22b41de2acbaea9211850fc5 | src/Model/HomepageForm.php | [View secret](https://github.com/Jexinte/P5---Blog-Professionnel---Openclassrooms/commit/5cecedffe752e91b22b41de2acbaea9211850fc5#diff-2115caac672bbbdd17ad2d0b3d546bfd7c4a0624699e51536bd41f4d6a29cec9R78) | | [7231695](https://dashboard.gitguardian.com/incidents/7231695?occurrence=100626505) | SMTP credentials | 833da46171dd394cae9f90480f0872c65a8c6e04 | src/Model/HomepageForm.php | [View secret](https://github.com/Jexinte/P5---Blog-Professionnel---Openclassrooms/commit/833da46171dd394cae9f90480f0872c65a8c6e04#diff-2115caac672bbbdd17ad2d0b3d546bfd7c4a0624699e51536bd41f4d6a29cec9L76) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secrets safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate these secrets](https://docs.gitguardian.com/secrets-detection/detectors/specifics/smtp_assignment#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!