search

JeysonFlores / switcher

Set default wallpapers for Dark & Light mode.
GNU General Public License v3.0
20 stars 2 forks source link

Simplify settings further #17

Open lukors opened 2 years ago

lukors commented 2 years ago

I think the settings could be simplified down to a single toggle.

There are two settings now: keep running after window closes, and run on startup. I'm not convinced having these two separate settings solves any use case.

For instance: what's the use case for keeping the app running in the background, but not launch it again on startup? And what's the use case for not running it in background, but then launching it when the computer restarts?

I think people are only interested in "is the app active or not", meaning both of these can be tied to the same toggle called something like "enabled". Either the app is enabled, meaning it changes the wallpaper based on light/dark mode in the background and across reboots, or it's not enabled, meaning it does nothing and does not run in the background.

Here are some benefits I see with this approach:

  1. It's simpler to understand.
  2. The settings popover can be replaced with the toggle, simplifying the interface.
  3. When this toggle is off the rest of the app can be "greyed out" or similar to indicate that "none of this stuff will actually do anything".
JeysonFlores commented 2 years ago

I made it this way firstly for debugging purposes. I first coded one process and then I coded the other, so maintaining a distinction between them was something I did naturally.

what's the use case for keeping the app running in the background, but not launch it again on startup?

It sounds strange but I use Switcher in that way. I don't like apps running at startup(because I have a quite slow laptop and having many apps running at startup slows my laptop down a lot, not by switcher itself but I have other apps that do the same thing) so in my current configuration I have disabled the "running at startup" option but I have enabled the "persistent mode" option. So everytime I want to use switcher I open it myself.

lukors commented 2 years ago

That's fair enough.

I would argue that this is a pretty niche use case, and I think the benefits outweigh the cons.

But it's your application so you make the calls. :)