search

JeysonFlores / switcher

Set default wallpapers for Dark & Light mode.
GNU General Public License v3.0
20 stars 2 forks source link

Change accent color too #5

Closed lukors closed 2 years ago

lukors commented 2 years ago

Different wallpapers go well with different accent colors. It would be nice if an accent color could be chosen for each wallpaper as well.

A good example of this is the default Odin wallpaper and its dark version. The default wallpaper goes well with Blueberry, but the dark version goes better with Mint.

JeysonFlores commented 2 years ago

The way switcher triggers the mode switching events is thru the Granite.Settings class, which is basically a wrapper around the DBus signal that sends the desktop when the Style Mode is changed. Granite doesn't provide any interface to catch Accent Colors settings signal (You can check the class documentation here). However it seems that in the code of the Desktop Plug when the accent color changes, it does creates a signal on DBus, so in order to implement just the triggering of the signal, a wrapper for it must be handcoded.

JeysonFlores commented 2 years ago

I think this improvement would be more pertinent in the case of a version 2. Which will come until other issues and UI stuff get solved. There are more urgent things to be fixed,

lukors commented 2 years ago

I just noticed that in elementary OS 6.1 there is a setting to automatically pick an accent color from the background image.

This fills my needs very nicely, so as far as I'm concerned this issue can be closed unless you want to keep it.