JezerM / nody-greeter

LightDM greeter that allows to create wonderful themes with web technologies. Made in Node.js
https://web-greeter-page.vercel.app
GNU General Public License v3.0
125 stars 8 forks source link

failed to build asar package #29

Closed LiveEmily closed 1 year ago

LiveEmily commented 1 year ago

Environment

Bug description

When trying to build, packaging the asar throws an error having to do with python.

Steps to reproduce

Clone the repo recursively, install npm dependencies, run rebuild, run build.

Expected behavior

Package should build successfully so you can continue with installing

Screenshots

image

JezerM commented 1 year ago

Seems to be an upstream error about node-gyp-bins. I'll look for a solution soon~

cy1der commented 1 year ago

Any fix yet?

JezerM commented 1 year ago

No, sorry, I haven't had time to see through this error. Also, it seems there is a PR trying to solve it in nody-gyp, but it hasn't been completed nor merged yet.

sachin746 commented 1 year ago

just trying to install this greeter same error image

JezerM commented 1 year ago

Well, I fixed this issue by patching the asar package. This isn't ideal, and it's not the best way to do it as it should've been done in the node-gyp package, but it works. Tell me if it works~

Use the master branch and build nody-greeter again. Also, sorry for the late fix, I was very busy these 3 months xd

cy1der commented 1 year ago

Thanks, I will test it later today. Also, does this greeter work with themes for WebKit?

cy1der commented 1 year ago

Now I'm unable to run npm install. 2022-12-22T15_15_16_526Z-debug-0.log Latest node, npm and node-gyp version

JezerM commented 1 year ago

@Cy1der, nodejs v19 is not supported by node-gtk yet, as stated in their README:

Supported Node.js versions: 14, 16, 17, 18 (other versions should work but are untested)

So, I'd recommend you to use an older version of nodejs.

cy1der commented 1 year ago

How to switch to older version?

JezerM commented 1 year ago

Well, it depends on your package management system. If using ArchLinux, install the nodejs-lts-hydrogen package, which is nodejs v18.